Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages and many small fixes #34

Merged
merged 36 commits into from
Mar 10, 2023
Merged

Update packages and many small fixes #34

merged 36 commits into from
Mar 10, 2023

Conversation

DeionSi
Copy link
Contributor

@DeionSi DeionSi commented Jan 15, 2023

This pull request does multiple things. It was not feasible for me to develop them separately from each other as they are intertwined in many cases.

  • Update all packages to latest version. Remove json5 dependency. Replace serialport with the sub-dependancy of @serialport/bindings-cpp. Remove deprecated request package and replace with native fetch. A lot of small changes as a result electron upgrade.
  • Use NPM jQuery instead of included.
  • Improve styling of selects
  • Imrpove top bar handling (including hiding firmware details which couldn't be clicked on)
  • Re-enable scrolling between the different pages. Changed all button handling to trigger this scrolling.
  • General improved layouts of the different pages.
  • Made base tune warning message into a separate page instead of a separate window.
  • Fix opening ini folder on Windows

Details are in the commits. All functions are working for me with a mega ECU.

Closes #33, #32. #31, #29, #28, #25, #24, #20, #16

@DeionSi
Update most packages
8daffef
@DeionSi
Package name must be lowercase
308a4dc
@DeionSi
Disable context isolation
c737cad
@DeionSi
Fix version in title update
9e8b0d8
@DeionSi
Another version fix
a688e48
@DeionSi
Fix serialport listing
ce30a00
@DeionSi
Function is not available
e650a08
@DeionSi
IE is deprecated and not used
90e9613
@DeionSi
Add breakpoints
0243454
@DeionSi
Fix firmware details
025098d
@DeionSi
Remove duplicate firmware details
f69dd3a
@DeionSi
Firmware details was highlighted at startup. Hide it instead.
ba85ce2
@DeionSi
Smooth page switches
6fe5f6d
@DeionSi
Increase scrolling speed
bed363d
@DeionSi
Make all links smooth
f1aa431
@DeionSi
Also remove the last entry of the select
07caef4
@DeionSi
Make all pages fit
0d8a13a
@DeionSi
Matching page headings
47138e6
@DeionSi
Neutral select options background color
5f7a20f
@DeionSi
Make sidebar not dissappear as easily
5559f81
@DeionSi
Reimplement warning message as a page
c710b5c
@DeionSi
Fix quit button
d3f76d2
@DeionSi
Replace two uses of deprecated request
1a809c3
@DeionSi
Replace request and JSON5
d6d77b9
@DeionSi
Remove logging
f067f0f
@DeionSi
Open links in default browser
3f75e15
@DeionSi
Use npm jquery
d809f5f
@DeionSi
Move button handlers from template to renderer
8836674
@DeionSi
Minor fixes
a2800ec
@DeionSi
Remove remote modules usage
39ffc65
@noisymime
Copy link
Collaborator

Looks good and tests out fine! Great work with those dependencies as some of them are a huge mess.

There's a couple of very small layout things I'm not convinced about (The warnings screen change for example) but nothing major and all just stylistic choices.

@noisymime noisymime merged commit 98e7d72 into speeduino:master Mar 10, 2023
@DeionSi DeionSi deleted the update-packages branch March 10, 2023 05:42
@DeionSi
Copy link
Contributor Author

DeionSi commented Mar 10, 2023

Thank you. Please close the pull requests this supercedes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeionSi @noisymime